Oved Ourfali has posted comments on this change. Change subject: java: support for oVirt SDK ......................................................................
Patch Set 6: Looks good to me, approved (1 inline comment) One comment. Not a crucial one, and can be added later as well, so giving +2 in the meantime. .................................................... File java/javauserportal/README Line 4: $ mvn clean install Line 5: Line 6: Deploy the war (in this case JBoss 7.1): Line 7: $ cp target/javauserportal.war /usr/local/jboss-as-8.1.1.Final/standalone/deployments/ Line 8: It would be nice to have a -Pdep option, like we have on the oVirt engine. -- To view, visit http://gerrit.ovirt.org/11092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab9134ab61e136a3eb1ccc85bdef7aac728a2f7 Gerrit-PatchSet: 6 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
