Alex Lourie has posted comments on this change. Change subject: packaging: creating a version file for fetching product version ......................................................................
Patch Set 2: (1 inline comment) .................................................... File packaging/fedora/setup/common_utils.py Line 1334: Line 1335: def getEngineVersion(): Line 1336: # Just read the info from the file Line 1337: with open(basedefs.FILE_ENGINE_VERSION) as version: Line 1338: return version.readlines()[0] echo -n in Makefile works without this. Arguably though, I'd change it to just return version.read() Line 1339: Line 1340: def installed(rpm): Line 1341: try: Line 1342: getRpmVersion(rpmName=rpm) -- To view, visit http://gerrit.ovirt.org/11383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I479668e0d82007d283743f732067d58c73d1ea15 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
