Allon Mureinik has posted comments on this change. Change subject: core: rename remove storage connection command ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) .................................................... Commit Message Line 5: CommitDate: 2013-01-24 17:02:21 +0200 Line 6: Line 7: core: rename remove storage connection command Line 8: Line 9: Rename removeStorageServerConnection command and vdcAction type s/vdcAction/VdcAction/ Line 10: to disconnectStorageServerConnection since this command Line 11: disconnects it on vdsm side, but does not remove its record from the db. Line 12: It's more correct to call it "disconnect" according to what it actually does. Line 13: It's also preparation for adding (in different patch) a remove command Line 12: It's more correct to call it "disconnect" according to what it actually does. Line 13: It's also preparation for adding (in different patch) a remove command Line 14: that actully both disconnects the storage and removes the storage connection from Line 15: the db. Line 16: I'd also add a sentence about disconnect and connect being symmetrical. Line 17: Change-Id: I0b6043810a5c4200593befd668a279ea56ff4693 -- To view, visit http://gerrit.ovirt.org/11378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b6043810a5c4200593befd668a279ea56ff4693 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
