Allon Mureinik has posted comments on this change.

Change subject: core: add test for duplicate keys in appErrors
......................................................................


Patch Set 2: (2 inline comments)

please rebase on top of master instead of the abandoned 
I5a0a83704c48a0c8250fa3a2a71ac2328c24f6a7 - it's quite annoying to review like 
this.

....................................................
Commit Message
Line 3: AuthorDate: 2013-01-23 16:38:37 +0200
Line 4: Commit:     Alissa Bonas <abo...@redhat.com>
Line 5: CommitDate: 2013-01-23 22:15:15 +0200
Line 6: 
Line 7: core: add test for duplicate keys in appErrors
s/core/core, webadmin, userportal/
Line 8: 
Line 9: The tests introduced in this patch check if in AppErrors.properties
Line 10: files in 3 locations there are duplicate keys (Same key with different
Line 11: message)


Line 6: 
Line 7: core: add test for duplicate keys in appErrors
Line 8: 
Line 9: The tests introduced in this patch check if in AppErrors.properties
Line 10: files in 3 locations there are duplicate keys (Same key with different
s/Same/same/
Line 11: message)
Line 12: 
Line 13: Change-Id: I143cb08908db4feed84ec2b94a17d89c1e522951


--
To view, visit http://gerrit.ovirt.org/11343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I143cb08908db4feed84ec2b94a17d89c1e522951
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to