Tal Nisan has posted comments on this change.
Change subject: core: Refactor SP validation out of ImagesHandler
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
Minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 228: boolean firstTime = true;
Line 229: SnapshotsValidator snapshotsValidator = new
SnapshotsValidator();
Line 230: List<Disk> diskList = Arrays.asList(getDisk());
Line 231:
Line 232: if (!listVms.isEmpty()) {
I think it's more elegant to use getVmsForDiskId() instead of listVms, also in
line 239
Line 233: storage_pool sp =
getStoragePoolDAO().get(listVms.get(0).getStoragePoolId());
Line 234: if (!validate(new StoragePoolValidator(sp).isUp())) {
Line 235: return false;
Line 236: }
--
To view, visit http://gerrit.ovirt.org/11323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5caa3724fb73c8fa8932c8071f6d27a78d681bb3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
