Alissa Bonas has uploaded a new change for review.
Change subject: core: create prop in frontend pom for engine core
......................................................................
core: create prop in frontend pom for engine core
Create a property "engine.core.groupId" in frontend pom
and use it in all inheriting poms instead of using hardcoded string for
group id "org.ovirt.engine.core"
Change-Id: I06b4e2886196ae4fdb7580033a83ec651adf1b11
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M frontend/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
7 files changed, 12 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/11365/1
diff --git a/frontend/pom.xml b/frontend/pom.xml
index c66b121..b4a41cd 100644
--- a/frontend/pom.xml
+++ b/frontend/pom.xml
@@ -19,6 +19,7 @@
<engine.groupId>org.ovirt.engine.ui</engine.groupId>
<engine.version>3.2.0</engine.version>
<aspectj.version>1.6.11</aspectj.version>
+ <engine.core.groupId>org.ovirt.engine.core</engine.core.groupId>
</properties>
<build>
<pluginManagement>
diff --git a/frontend/webadmin/modules/frontend/pom.xml
b/frontend/webadmin/modules/frontend/pom.xml
index d256ffb..c5490b1 100644
--- a/frontend/webadmin/modules/frontend/pom.xml
+++ b/frontend/webadmin/modules/frontend/pom.xml
@@ -32,13 +32,13 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>utils</artifactId>
<version>${engine.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>common</artifactId>
<version>${engine.version}</version>
<scope>provided</scope>
diff --git a/frontend/webadmin/modules/gwt-extension/pom.xml
b/frontend/webadmin/modules/gwt-extension/pom.xml
index 57cdd47..d1cbd78 100644
--- a/frontend/webadmin/modules/gwt-extension/pom.xml
+++ b/frontend/webadmin/modules/gwt-extension/pom.xml
@@ -35,13 +35,13 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>common</artifactId>
<version>${engine.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>utils</artifactId>
<version>${engine.version}</version>
<scope>provided</scope>
diff --git a/frontend/webadmin/modules/uicommonweb/pom.xml
b/frontend/webadmin/modules/uicommonweb/pom.xml
index 20146cb..523e8b6 100644
--- a/frontend/webadmin/modules/uicommonweb/pom.xml
+++ b/frontend/webadmin/modules/uicommonweb/pom.xml
@@ -15,7 +15,7 @@
<dependencies>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>searchbackend</artifactId>
<version>${project.version}</version>
</dependency>
diff --git a/frontend/webadmin/modules/uicompat/pom.xml
b/frontend/webadmin/modules/uicompat/pom.xml
index ff1176e..a3bd840 100644
--- a/frontend/webadmin/modules/uicompat/pom.xml
+++ b/frontend/webadmin/modules/uicompat/pom.xml
@@ -11,24 +11,24 @@
<name>UI Utils Compatibility (for UICommon)</name>
<dependencies>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>common</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>common</artifactId>
<classifier>sources</classifier>
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>compat</artifactId>
<classifier>sources</classifier>
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>searchbackend</artifactId>
<classifier>sources</classifier>
<version>${project.version}</version>
diff --git a/frontend/webadmin/modules/userportal-gwtp/pom.xml
b/frontend/webadmin/modules/userportal-gwtp/pom.xml
index 2996531..a584e33 100644
--- a/frontend/webadmin/modules/userportal-gwtp/pom.xml
+++ b/frontend/webadmin/modules/userportal-gwtp/pom.xml
@@ -102,7 +102,7 @@
<version>${engine.version}</version>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>utils</artifactId>
<version>${engine.version}</version>
<scope>provided</scope>
diff --git a/frontend/webadmin/modules/webadmin/pom.xml
b/frontend/webadmin/modules/webadmin/pom.xml
index f15a529..021faee 100644
--- a/frontend/webadmin/modules/webadmin/pom.xml
+++ b/frontend/webadmin/modules/webadmin/pom.xml
@@ -119,7 +119,7 @@
<version>${aspectj.version}</version>
</dependency>
<dependency>
- <groupId>org.ovirt.engine.core</groupId>
+ <groupId>${engine.core.groupId}</groupId>
<artifactId>utils</artifactId>
<version>${engine.version}</version>
<scope>provided</scope>
--
To view, visit http://gerrit.ovirt.org/11365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06b4e2886196ae4fdb7580033a83ec651adf1b11
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
