Tomas Jelinek has posted comments on this change. Change subject: restapi: [RFE] Display Address Override ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1240: <xs:element name="os" type="OperatingSystem" minOccurs="0" maxOccurs="1"/> Line 1241: <xs:element ref="hooks" minOccurs="0"/> Line 1242: <xs:element name="libvirt_version" type="Version" minOccurs="0" maxOccurs="1"/> Line 1243: <!-- Optionally specify the display address of this host explicitly --> Line 1244: <xs:element name="display" type="Display" minOccurs="0" maxOccurs="1"/> but there is no element named Display - so the compilation fails on: "Cannot resolve the name 'Display' to a(n) 'element declaration' component" In order to do it using the ref I would need to first add: <xs:element name="display" type="Display"/> and than I can: <xs:element ref="display" minOccurs="0"/> So, which one would you rather have? The way it is in this patch set or to declare the display element? Line 1245: </xs:sequence> Line 1246: </xs:extension> Line 1247: </xs:complexContent> Line 1248: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/9027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I105881365d2c23638a1a9ad4db3b82a352f039e3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
