Liron Aravot has posted comments on this change. Change subject: core:AddVdsSpmIdCommand throw exception when... ......................................................................
Patch Set 2: I would prefer that you didn't submit this 1. Yair, the config value will be enforced in the canDoAction..i guess eli just assumed that this is the max value that will ever be. 2. Eli, can you give link to logs or bug#? I don't see how do we have this issue, the PK of the table is the storage pool id + host id, so how can we have pk violation? furthermore, only one host can add this record through transaction beacuse of the lock, can you elaborate when and how it happend? 3. If pk violation does occur now, how this stored procedure will prevent it? when we read from the table during the insert someone might insert record with same value, it's not prevented, 4. I prefer to not have this logic on stored procedure, no way to debug it, harder to check for errors. -- To view, visit http://gerrit.ovirt.org/11271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f8aa6b6cb3dfc1508a99c53553afc2e15009b68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
