Gilad Chaplik has posted comments on this change. Change subject: webadmin: [RFE] Display Address Override ......................................................................
Patch Set 6: (1 inline comment) see my comment, I'd even consider adding this property to cluster view. since recently we have one http://gerrit.ovirt.org/#/c/11070/ .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java Line 240: new INewAsyncCallback() { Line 241: @Override Line 242: public void OnSuccess(Object target, Object returnValue) { Line 243: @SuppressWarnings("unchecked") Line 244: boolean toShowWarning = isConsoleAddressPartiallyOverridden((List<VDS>) ((VdcQueryReturnValue) returnValue).getReturnValue()); fetch all hosts in cluster for a single boolean? please write a query to retrieve it. Line 245: setConsoleAddressPartiallyOverridden(toShowWarning); Line 246: } Line 247: } Line 248: ); -- To view, visit http://gerrit.ovirt.org/9023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47674a1ecde457c51934e8ad262639567902a9be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
