Allon Mureinik has posted comments on this change.
Change subject: core: MoveOrCopyImageGroup - fixes to revertTasks
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
Line 194: Guid destImageId =
getParameters().getDestinationImageId();
Line 195: RemoveImageParameters removeImageParams =
Line 196: new RemoveImageParameters(destImageId);
Line 197: removeImageParams.setParentParameters(removeImageParams);
Line 198:
removeImageParams.setParentCommand(VdcActionType.RemoveImage);
AFAIK, you should just leave both of these null
Line 199: if (getParameters().getParentCommand() ==
VdcActionType.ImportVm) {
Line 200: removeImageParams.setRemoveDuringExecution(false);
Line 201: removeImageParams.setRemoveFromDB(true);
Line 202: }
--
To view, visit http://gerrit.ovirt.org/11329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f767fcfa05d48ba085910dac7a1b746601381a9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
