Juan Hernandez has posted comments on this change.
Change subject: packaging: Application Mode option in installer
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
Please verify.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 180: controller.addSequence(item['description'],
item['condition'], item['condition_match'], item['steps'])
Line 181:
Line 182:
Line 183: def _useDefaultDcType(conf):
Line 184: return True if utils.isApplicationModeGluster(conf) else False
This could be:
def _useDefaultDcType(conf):
return utils.isApplicationModeGluster(conf)
Line 185:
Line 186:
Line 187: def _useDefaultConfigNfs(conf):
Line 188: # When gluster mode is selected then don't ask the questions
related
--
To view, visit http://gerrit.ovirt.org/9991
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
