Eli Mesika has uploaded a new change for review. Change subject: core: taskcleaner.sh utility outputs extra lines ......................................................................
core: taskcleaner.sh utility outputs extra lines When using taskcleaner.sh utility to list task or zombie tasks, the utility outputs extra lines. The directories in the output are the result of pushd and popd using in the script to make it runnable from any place by its full name. When the utility returns no data, it is important that no redundant output is generated in order to track this correctly. Change-Id: I5bf28cfe2311449a0bdd68e132622ced57d4a868 Signed-off-by: Eli Mesika <emes...@redhat.com> Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=903156 --- M backend/manager/dbscripts/taskcleaner.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/11298/1 diff --git a/backend/manager/dbscripts/taskcleaner.sh b/backend/manager/dbscripts/taskcleaner.sh index 65525bd..bad1a7b 100755 --- a/backend/manager/dbscripts/taskcleaner.sh +++ b/backend/manager/dbscripts/taskcleaner.sh @@ -17,7 +17,7 @@ ############################################################################################################### #!/bin/bash -pushd $(dirname ${0}) +pushd $(dirname ${0})>/dev/null #include db general functions source ./dbfunctions.sh @@ -45,7 +45,7 @@ printf "\t-v - Turn on verbosity (WARNING: lots of output)\n" printf "\t-h - This help text.\n" printf "\n" - popd + popd>/dev/null exit $ret } @@ -97,7 +97,7 @@ read answer if [ "${answer}" = "n" ]; then echo "Please contact support for further assistance." - popd + popd>/dev/null exit 1 fi fi @@ -230,5 +230,5 @@ psql -U ${USERNAME} -h ${SERVERNAME} -p ${PORT} -c "${CMD1}${CMD2}" -x ${DATABASE} -popd +popd>/dev/null exit $? -- To view, visit http://gerrit.ovirt.org/11298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5bf28cfe2311449a0bdd68e132622ced57d4a868 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches