Gilad Chaplik has uploaded a new change for review.

Change subject: webadmin: wrong compatibility version prompt in new DC
......................................................................

webadmin: wrong compatibility version prompt in new DC

In case a DC was selected in grid and new DC button was pressed, we
opened the compatibility version changed dialog wrongfuly.

Added isNew DC check.

Change-Id: I85fbabe1117c64896772a52f533868d3c4a349b2
Signed-off-by: Gilad Chaplik <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/11255/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
index 47df657..d5550bb 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
@@ -612,9 +612,9 @@
                 && model.getQuotaEnforceTypeListModel().getSelectedItem() != 
QuotaEnforcementTypeEnum.DISABLED) {
             promptNoQuotaInDCMessage();
         }
-        else if (getSelectedItem() != null
-                && !((Version) 
model.getVersion().getSelectedItem()).equals(((storage_pool) 
getSelectedItem()).getcompatibility_version()))
-        {
+        else if (!model.getIsNew()
+                && getSelectedItem() != null
+                && !((Version) 
model.getVersion().getSelectedItem()).equals(((storage_pool) 
getSelectedItem()).getcompatibility_version())) {
             ConfirmationModel confirmModel = new ConfirmationModel();
             setConfirmWindow(confirmModel);
             confirmModel.setTitle(ConstantsManager.getInstance()


--
To view, visit http://gerrit.ovirt.org/11255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85fbabe1117c64896772a52f533868d3c4a349b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to