Kanagaraj M has posted comments on this change.
Change subject: engine: Enable gluster hook command
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 137: }
Line 138:
Line 139: protected void UpdateHookStatusInDb(Guid clusterId, String
hookName, GlusterHookStatus status) {
Line 140: getGlusterHookDao().updateGlusterHookStatusByName(clusterId,
hookName, status);
Line 141: }
Please remove this method from here.
Line 142:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java
Line 22: return getClusterUtils().getAllUpServers(clusterId);
Line 23: }
Line 24:
Line 25: @Override
Line 26: protected boolean canDoAction() {
we are not doing anything here, then why to override?
Line 27: return super.canDoAction();
Line 28: }
Line 29:
Line 30: @Override
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookParameters.java
Line 14:
Line 15: @NotNull(message = "VALIDATION.GLUSTER.VOLUME.CLUSTER_ID.NOT_NULL")
Line 16: private Guid clusterId;
Line 17:
Line 18: private Guid hookId;
i think we need NOT_NULL validation here as well.
Line 19:
Line 20: public GlusterHookParameters(Guid clusterId,
Line 21: Guid hookId) {
Line 22: setClusterId(clusterId);
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 820: ACTION_TYPE_FAILED_CAN_NOT_INCREASE_STRIPE_COUNT_MORE_THAN_ONE=Cannot
${action} ${type}. Stripe count cannot be increased by more than one.
Line 821: ACTION_TYPE_FAILED_CAN_NOT_REDUCE_STRIPE_COUNT=Cannot ${action}
${type}. Stripe count can not be reduced.
Line 822: ACTION_TYPE_FAILED_NO_UP_SERVER_FOUND=Cannot ${action} ${type}. No up
server found in ${clusterName}.
Line 823: ACTION_TYPE_FAILED_BRICK_ALREADY_EXISTS_IN_VOLUME=Cannot ${action}
${type}. Brick ${brick} already used by the volume ${volumeName}.
Line 824: ACTION_TYPE_FAILED_GLUSTER_HOOK_ID_IS_REQUIRED=Cannot ${action}
${type}. Gluster hook id is required.
Are we not using NO_UP_SERVER_FOUND anywhere?
Line 825: ERROR_GET_STORAGE_DOMAIN_LIST=Cannot get Storage Domains list.
Line 826: VDS_CANNOT_REMOVE_HOST_HAVING_GLUSTER_VOLUME=Cannot remove gluster
server. Server having Gluster volume(s).
Line 827:
ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_AND_MIGRATABLE=Migratable VM's
cannot be pinned to CPU.
Line 828: ACTION_TYPE_FAILED_NETWORK_INTERFACE_MAC_INVALID=Cannot ${action}
${type}. The Network Interface ${IfaceName} has an invalid MAC address
${MacAddress}. MAC address must be in format "HH:HH:HH:HH:HH:HH" where H is a
hexadecimal character (either a digit or A-F, case is insignificant).
--
To view, visit http://gerrit.ovirt.org/10906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc6f9c77393ebed2803ec2a1b295a09f61642c31
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
