Juan Hernandez has posted comments on this change.
Change subject: core: Update StoragePoolValidator test to test GlusterFS.
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 196: }
Line 197: if (returnValue) {
Line 198: returnValue =
validator.isPosixDcAndMatchingCompatiblityVersion();
Line 199: }
Line 200: if (!returnValue) {
Shouldn't this condition be just "if (returnValue)" without the negation? With
the negation if something failed prior to this code (for example if the name
already exists) then the value will be discarded and replaced with the outcome
of "isGlusterDc...".
Line 201: returnValue =
validator.isGlusterDcAndMatchingCompatiblityVersion();
Line 202: }
Line 203: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
Line 204: return returnValue;
--
To view, visit http://gerrit.ovirt.org/8836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4cd98cd06716c31248d8ec4f21a3a6f79f13102
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
