Shireesh Anjal has posted comments on this change. Change subject: gluster: Make set option a step of create volume ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java Line 61: if (jobProperties == null) { Line 62: jobProperties = super.getJobMessageProperties(); Line 63: } Line 64: Line 65: jobProperties.put(GlusterConstants.VOLUME, volume.getName()); Is getJobMessageProperties() called multiple times in the lifecycle of a command? Line 66: return jobProperties; Line 67: } Line 68: Line 69: @Override -- To view, visit http://gerrit.ovirt.org/10905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0f22e9862584f1a616fcc01e8a80b7d5a5ffc78 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches