Vijay Bellur has posted comments on this change.

Change subject: gluster: Log details of option being set
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java
Line 29:     public Map<String, String> getCustomValues() {
Line 30:         AddCustomValue(GlusterConstants.OPTION_KEY, 
getParameters().getVolumeOption().getKey());
Line 31:         AddCustomValue(GlusterConstants.OPTION_VALUE, 
getParameters().getVolumeOption().getValue());
Line 32:         return super.getCustomValues();
Line 33:     }
There is no sensitive data that is set as an volume option in GlusterFS 
currently.
Line 34: 
Line 35:     @Override
Line 36:     protected void setActionMessageParameters() {
Line 37:         addCanDoActionMessage(VdcBllMessages.VAR__ACTION__SET);


--
To view, visit http://gerrit.ovirt.org/10908
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c5b4712128056a4ba5f1d87cf8fd9114f95116b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbel...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to