Moti Asayag has posted comments on this change. Change subject: engine: Refactored code into NetworkValidator class ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java Line 54: public void setup() { Line 55: Line 56: // spy on attempts to access the database Line 57: validator = spy(new NetworkValidator(network)); Line 58: doReturn(dataCenter).when(validator).getDataCenter(); Please ignore this comment - it is not relevant since you're using spy() Line 59: doReturn(networks).when(validator).getNetworks(); Line 60: Line 61: // mock version checking Line 62: Version version = mock(Version.class); -- To view, visit http://gerrit.ovirt.org/10940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches