Greg Padgett has posted comments on this change. Change subject: core, db: add cluster view ......................................................................
Patch Set 2: > Regarding my searchBackend note: it seems that the search already has the > ability to join with dc name prior to your patch, so is it worth > investigating whether we have duplicate code? I meant to comment on the search backend before, thanks for bringing it up. With the vds_group dao now having storage_pool_name so the UI can retrieve it, the views used by the search backend now also have to return it. I tried just now using vds_group instead of vds_group_view in the search backend and got an exception, which distils down to this: ERROR [...] The column name storage_pool_name was not found in this ResultSet. -- To view, visit http://gerrit.ovirt.org/11070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5847d234e396fe8a83017fb25a5139f552e7c61b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
