Maor Lipchuk has posted comments on this change. Change subject: core: Add validation for DC's compatability. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java Line 283: protected boolean canDoAction() { Line 284: boolean result = true; Line 285: if (!canDoSnapshot(getVm())) { Line 286: return false; Line 287: } I don't think it is that relevant, if it will bother anyone else I will change it Line 288: List<DiskImage> disksList = getDisksList(); Line 289: if (disksList.size() > 0) { Line 290: VmValidator vmValidator = new VmValidator(getVm()); Line 291: result = validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) -- To view, visit http://gerrit.ovirt.org/11107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77e301643b3ac9789cc5eb7527b6a5a4a0aac6be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches