Itamar Heim has posted comments on this change. Change subject: core: Added Provider class ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java Line 11: private String name; Line 12: Line 13: private String description; Line 14: Line 15: private String apiAddress; i was thinking field name. if anything, address is closer to IP Address, than URI/URL which are the full path (IP/PORT/entrypoint). oh, check http://www.ovirt.org/Network_Provider, the one who wrote that also thought URI :) Line 16: Line 17: public String getName() { Line 18: return name; Line 19: } -- To view, visit http://gerrit.ovirt.org/10783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e42286f513cf47dd057a6078ea365d6dff24e9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
