Mike Kolesnik has uploaded a new change for review.

Change subject: engine: Replace NetworkDaoDbFacadeImpl.getByName()
......................................................................

engine: Replace NetworkDaoDbFacadeImpl.getByName()

Old call was using an archaic API, replace by the standard way to run
JDBCTemplate queries.

Change-Id: I18ced945229f34ce6a042ae6f46970e6b2b0f395
Signed-off-by: Mike Kolesnik <mkole...@redhat.com>
---
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
1 file changed, 3 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/11111/1

diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
index 2e518c1..0e61ccd 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java
@@ -3,13 +3,11 @@
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.List;
-import java.util.Map;
 
 import org.ovirt.engine.core.common.businessentities.network.Network;
 import org.ovirt.engine.core.common.businessentities.network.NetworkCluster;
 import org.ovirt.engine.core.common.businessentities.network.NetworkStatus;
 import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.dal.dbbroker.DbFacadeUtils;
 import org.ovirt.engine.core.dao.DefaultGenericDaoDbFacade;
 import org.springframework.jdbc.core.namedparam.MapSqlParameterSource;
 import org.springframework.jdbc.core.simple.ParameterizedRowMapper;
@@ -24,14 +22,9 @@
 
     @Override
     public Network getByName(String name) {
-        Map<String, Object> dbResults = 
dialect.createJdbcCallForQuery(jdbcTemplate)
-                .withProcedureName("GetnetworkByName")
-                .returningResultSet("RETURN_VALUE", NetworkRowMapper.instance)
-                .execute(getCustomMapSqlParameterSource()
-                        .addValue("networkName", name));
-
-        return (Network) DbFacadeUtils.asSingleResult((List<?>) (dbResults
-                .get("RETURN_VALUE")));
+        return getCallsHandler().executeRead("GetnetworkByName",
+                NetworkRowMapper.instance,
+                getCustomMapSqlParameterSource().addValue("networkName", 
name));
     }
 
     @Override


--
To view, visit http://gerrit.ovirt.org/11111
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18ced945229f34ce6a042ae6f46970e6b2b0f395
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to