Liron Aravot has posted comments on this change. Change subject: core: Remove global lock on SPM calls from engine side ......................................................................
Patch Set 5: Michael, thanks. Michael, thanks. by the way, sorry for thinking of this now - if we have few spm commands that can run simultaneously and each can add a reconstruct operation to queue, we might have uneeded reconstructs if we submit one after the queue was cleared by previous reconstruct, which means that another uneeded reconstruct will run. because GetStoragePoolInfo will run always every few seconds, I think that it can be the only command that will trigger reconstruct in case of a failure. what do you think? we can also add the reconstruct and then fail it in can do action for example, but it will require loading the pool at the begining of each command - seems to me that GetStoragePoolInfo to be the only one that runs reconstruct in case of "master failure" should be the solution. -- To view, visit http://gerrit.ovirt.org/9298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
