Kanagaraj M has uploaded a new change for review. Change subject: webadmin: Fix remove bricks confirmation message ......................................................................
webadmin: Fix remove bricks confirmation message Changed the hash name to not add the remove message template. And updated the confirmation message for replicate volumes to make it uniform. Change-Id: Id931875d12aeb0acb646702c84bb3c07344eaa33 Bug-Url: https://bugzilla.redhat.com/893947 Signed-off-by: Kanagaraj M <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/11090/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java index 6304f0c..1c9d0d2 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java @@ -388,7 +388,7 @@ setWindow(model); model.setEntity(removeBrickModel.isReduceReplica()); model.setTitle(ConstantsManager.getInstance().getConstants().removeBricksTitle()); - model.setHashName("remove_bricks"); //$NON-NLS-1$ + model.setHashName("volume_remove_bricks"); //$NON-NLS-1$ if (removeBrickModel.isReduceReplica()) { model.setMessage(ConstantsManager.getInstance() diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java index 510b62c..87a6ae1 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java @@ -1412,7 +1412,7 @@ @DefaultStringValue("Error in fetching the brick details, please try again.") String errorInFetchingBrickAdvancedDetails(); - @DefaultStringValue("Are you sure want to remove the following Brick(s)?") + @DefaultStringValue("Are you sure you want to remove the following Brick(s)?") String removeBricksMessage(); @DefaultStringValue("NOTE:\n -Removing brick(s) can result in data loss.") diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java index 54da3ff..a602d27 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java @@ -129,7 +129,7 @@ @DefaultMessage("Used by VG: {0}") String lunUsedByVG(String vgID); - @DefaultMessage("Replica count will be reduced from {0} to {1} on removing the following bricks. Are you sure want to continue?") + @DefaultMessage("Replica count will be reduced from {0} to {1}. Are you sure you want to remove the following Brick(s)?") String removeBricksReplicateVolumeMessage(int oldReplicaCount, int newReplicaCount); @DefaultMessage("Break Bond {0}") -- To view, visit http://gerrit.ovirt.org/11090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id931875d12aeb0acb646702c84bb3c07344eaa33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
