Daniel Erez has posted comments on this change.
Change subject: webadmin: ie10 drag&drop support
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
Line 212: public static String getData(String dragDropEventData) {
Line 213: if (dragDropEventData == null) {
Line 214: return ""; //$NON-NLS-1$
Line 215: }
Line 216: int split = dragDropEventData.indexOf(" "); //$NON-NLS-1$
Why not using String's split() function instead?
Line 217: if (split == -1 || dragDropEventData.length() == split + 1) {
Line 218: return ""; //$NON-NLS-1$
Line 219: }
Line 220: return dragDropEventData.substring(split + 1);
--
To view, visit http://gerrit.ovirt.org/11077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5150a6c2b62322969d88d0e2f2a9a85621352d9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
