Allon Mureinik has posted comments on this change.
Change subject: core: RemoveImageCommand - avoid image staying LOCKED, revert
to ILLEGAL
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
please rebase, re-verify, and fix the comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 284: boolean isShouldBeLocked = getParameters().getParentCommand()
!= VdcActionType.RemoveVmFromImportExport
Line 285: && getParameters().getParentCommand() !=
VdcActionType.RemoveVmTemplateFromImportExport;
Line 286: if (isShouldBeLocked) {
Line 287: // the image status should be set to ILLEGAL, so that in
case compensation runs the image status will
Line 288: // be revert to ILLEGAL, as we can't tell were the task
started on vdsm side or not.
s/be//
s/were/whether/
Line 289: getDiskImage().setimageStatus(ImageStatus.ILLEGAL);
Line 290: lockImageWithCompensation();
Line 291: }
Line 292: // Releasing the lock for cases it was set by the parent
command. The lock can be released because the image
--
To view, visit http://gerrit.ovirt.org/11075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ec91a5f8b8495b8cfd11b19016fee5993644ba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
