Shireesh Anjal has posted comments on this change. Change subject: gluster: GlusterMultipleActionRunner ......................................................................
Patch Set 2: (2 inline comments) Responses to Michael's comments in-line. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java Line 46: case StopGlusterVolume: Line 47: case DeleteGlusterVolume: Line 48: case SetGlusterVolumeOption: Line 49: case ResetGlusterVolumeOptions: Line 50: case AddVds: // AddVds is called with multiple actions *only* in case of gluster clusters I've sent a patch to acquire a lock on the cluster if the host is being added to / removed from a gluster cluster. http://gerrit.ovirt.org/10850 Line 51: case RemoveGlusterServer: { Line 52: runner = new GlusterMultipleActionsRunner(actionType, parameters, isInternal); Line 53: break; Line 54: } Line 51: case RemoveGlusterServer: { Line 52: runner = new GlusterMultipleActionsRunner(actionType, parameters, isInternal); Line 53: break; Line 54: } Line 55: Same as above. Line 56: case RemoveVds: { Line 57: if(containsGlusterServer(parameters)) { Line 58: runner = new GlusterMultipleActionsRunner(actionType, parameters, isInternal); Line 59: } else { -- To view, visit http://gerrit.ovirt.org/10812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e3dc1fa0b21ab6e0fcaff518bf9696f6c9796ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
