Alissa Bonas has posted comments on this change.
Change subject: core: RemoveSnapshot vmDown validation
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 162: initializeObjectState();
Line 163:
Line 164: if (!validateVmNotDuringSnapshot() ||
Line 165: !validateSnapshotExists() ||
Line 166: !validate(new VmValidator(getVm()).vmDown()) ||
before the change, some of the checks could be not done because of the early
return. now all the validations are together in the same if - so now all of
them are performed together - isn't it a bit less efficient? (depending on the
checks content of course)
Line 167: !validateImagesAndVMStates()) {
Line 168: handleCanDoActionFailure();
Line 169: return false;
Line 170: }
--
To view, visit http://gerrit.ovirt.org/11014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd281aa6778a3249162517499b5f0f48b04ed6b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
