Allon Mureinik has posted comments on this change. Change subject: core: ExportVm vmDown validation ......................................................................
Patch Set 1: (1 inline comment) @Vered - yes. checkVmIsDown will be removed in http://gerrit.ovirt.org/#/c/11018/ .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java Line 151: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW); Line 152: return false; Line 153: } Line 154: Line 155: if (!(checkVmInStorageDomain() looks OK in eclipse/vi Line 156: && validate(new SnapshotsValidator().vmNotDuringSnapshot(getVmId())) Line 157: && validate(new VmValidator(getVm()).vmDown()) Line 158: && ImagesHandler.PerformImagesChecks(getVm(), Line 159: getReturnValue().getCanDoActionMessages(), -- To view, visit http://gerrit.ovirt.org/11016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d48868ea1a292e7b655f27e3984606d152f9866 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
