Moti Asayag has posted comments on this change.
Change subject: engine: Support Duplicate Mac Addresses
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
Line 218:
Line 219: private void internalFreeMac(String mac) {
Line 220: if (allocatedMacs.containsKey(mac)) {
Line 221: removeMacFromMap(allocatedMacs, mac);
Line 222: availableMacs.add(mac);
I'm troubled about this line:
Since the AllowDuplicateMacAddress configuration variable is reloadable, this
code won't serve well in case we moved from permissive to restrictive mode:
returning a MAC address to the available mac address pool should be done only
if it no longer in use by the allocatedMacs
Line 223: } else if (allocatedCustomMacs.containsKey(mac)) {
Line 224: removeMacFromMap(allocatedCustomMacs, mac);
Line 225: }
Line 226: }
--
To view, visit http://gerrit.ovirt.org/10698
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie96eda19de2d3a44e24806095fb690e4eba41165
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
