Moti Asayag has posted comments on this change.
Change subject: engine: check if host exists with same name
......................................................................
Patch Set 1: (1 inline comment)
Please add the same validation to UpdateVdsCommand to make sure not only a
creation of host with duplicate fails, but also an attempt to update an host to
existing host's name.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 630: ACTION_TYPE_FAILED_NAME_MAY_NOT_BE_EMPTY=Can not ${action} ${type}.
The given name is empty.
Line 631: ACTION_TYPE_FAILED_NAME_MAY_NOT_CONTAIN_SPECIAL_CHARS=Can not
${action} ${type}. The given name contains special characters. Only lower-case
and upper-case letters, numbers, '_', '-', '.' are allowed.
Line 632: ACTION_TYPE_FAILED_NAME_MAY_NOT_CONTAIN_SPECIAL_CHARS_OR_DASH=Can not
${action} ${type}. The given name contains special characters. Only lower-case
and upper-case letters, numbers, '_', allowed.
Line 633: ACTION_TYPE_FAILED_INVALID_VDS_HOSTNAME=Can not ${action} ${type}.
The given Host name is invalid. Only Host names corresponding to RFC-952 and
RFC-1123 are allowed.
Line 634: ACTION_TYPE_FAILED_DUPLICATE_VDS_NAME=Can not ${action} ${type}. Host
with the same name already exists.
this is a duplication of an error message - check for
VDS_TRY_CREATE_WITH_EXISTING_PARAMS inside this file.
Line 635: VM_CANNOT_RUN_ONCE_WITH_ILLEGAL_SYSPREP_PARAM=Missing UserName or
Password.
Line 636: ACTION_TYPE_FAILED_CANNOT_REMOVE_BUILTIN_GROUP_EVERYONE=Cannot remove
the built-in group "Everyone".
Line 637: ACTION_TYPE_FAILED_IMPORT_DATA_DOMAIN_PROHIBITED=Importing data
domain is prohibited.
Line 638: ACTION_TYPE_FAILED_VDS_NOT_MATCH_VALID_STATUS=Cannot ${action}
${type}. Valid Host statuses are "Non operational", "Maintenance" or
"Connecting".
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4791d49b128126269d9b2b0c2e9bb35debf5a7ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
