Moti Asayag has posted comments on this change.
Change subject: engine : User is UNKNOWN in async task completion events
......................................................................
Patch Set 1: (1 inline comment)
I'm not sure the proposed solution is the best method to address this issue.
Job entity might not be always created, therefore this information (user name)
might be missing (at the moment each VDSM task has a Job entity to describe the
command that created it).
I think a more robust solution will be persisting any required data of the
command that should be consumed by the command completion flow (after the
command instance is no longer exists).
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1614: if (executionContext != null) {
Line 1615: setExecutionContext(executionContext);
Line 1616: if (executionContext.getJob() != null) {
Line 1617: if (executionContext.getJob().getOwnerId() != null) {
Line 1618: DbUser user =
DbFacade.getInstance().getDbUserDao().get(executionContext.getJob().getOwnerId().getValue());
please replace DbFacade.getInstance().getDbUserDao() with getDbUserDAO
Line 1619: if (user != null) {
Line 1620: setUserName(user.getusername());
Line 1621: }
Line 1622: }
--
To view, visit http://gerrit.ovirt.org/10896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0904f9f6d9432ecac1cebee3790eae902a1329a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
