Greg Padgett has posted comments on this change. Change subject: webadmin: improve behavior of bookmark list (2/2) ......................................................................
Patch Set 2: What the patch solves is being able to re-select the previously selected bookmark after we clear it using setSelected(cur, false), which we do if a user selects a bookmark, then navigates away from the bookmarked location. If they want to get back, they currently can't without first selecting a different bookmark because re-clicking on the same one doesn't do anything--the list thinks it's already selected due to the gwt bug, so it doesn't fire any selection-changed events. The issue isn't necessarily with keyboard selection itself, but IIUC it is caused by a lack of synchronization between the selected and keyboard-selected items. I believe it's in the gwt libraries and not a dom issue or similar, so even though it was raised on the browser/version combination you mentioned, it's still an open issue affecting all browsers. See also [1] and [2] for similar reports on various platforms. [1] http://code.google.com/p/google-web-toolkit/issues/detail?id=6787 [2] http://code.google.com/p/google-web-toolkit/issues/detail?id=7480 -- To view, visit http://gerrit.ovirt.org/10819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25a9e721d8b7ccd982708eadf579e9eb229dedd5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
