Barak Azulay has posted comments on this change. Change subject: [WIP] core: compensation should not clean entities with associated tasks ......................................................................
Patch Set 4: I would prefer that you didn't submit this After discussing the issue in depth with Liron, it looks like we are better off without this patch. Today the command mechanism relies on the compensation to be reverted on engine restart as a way to understand that not all subcommands were actually executed, hence each parent command need to validate all the new entities still exist in the DB (and not reverted ...). So today we are better off without this patch, as it will often falsely assume that the parent command succeeded (not reverted) even some of it's sub commands did not even start. -- To view, visit http://gerrit.ovirt.org/9122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
