Juan Hernandez has posted comments on this change.

Change subject: packaging: Use temporary modules directory
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File packaging/fedora/engine-service.py
Line 420:     engineModulesDir = os.path.join(engineUsrDir, "modules")
Line 421: 
Line 422:     # Link all the JBoss modules into a temporary directory:
Line 423:     jbossModulesTmpDir = os.path.join(engineTmpDir, "modules")
Line 424:     if not os.path.exists(jbossModulesTmpDir):
The temporary directory is already removed completely before starting, see line 
384.
Line 425:         os.mkdir(jbossModulesTmpDir)
Line 426:     linkModules(jbossModulesDir, jbossModulesTmpDir)
Line 427: 
Line 428:     # Module path should include first the engine modules so that 
they can override


--
To view, visit http://gerrit.ovirt.org/10292
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f27390a232df42b477dc0e9abe7909e10d9abb1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to