Gilad Chaplik has posted comments on this change.

Change subject: webadmin: WIP: Create storage domains using Gluster FS.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
Line 384:                 item = PreparePosixStorageForEdit(storage);
Line 385:                 break;
Line 386: 
Line 387:             case GLUSTERFS:
Line 388:                 item = PrepareGlusterStorageForEdit(storage);
maybe first needs a clean-up, but for newly created methods, use java name 
conventions
Line 389:                 break;
Line 390:         }
Line 391: 
Line 392:         model.setItems(new ArrayList<IStorageModel>(Arrays.asList(new 
IStorageModel[] {item})));


--
To view, visit http://gerrit.ovirt.org/8983
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia74870ea95a103ecdd228a26d314ff66e2fcc675
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to