Muli Salem has posted comments on this change. Change subject: engine: Restrict vlan-id range to 0-4094 ......................................................................
Patch Set 1: Looks good to me, approved (2 inline comments) Very minor comment, other than that +2. .................................................... File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 380: -If you have problems with the master Data Domain, consider following the recovery process described in the documentation, or contact your system administrator. Line 381: Line 382: ERROR_CANNOT_DESTROY_LAST_STORAGE_DOMAIN_HOST_NOT_ACTIVE=In order to complete the operation a new master Storage Domain needs to be elected, which requires at least one active Host in the Data Center.\n\ Line 383: -Please make sure one of the Hosts is active in the Data Center first. Line 384: NETWORK_VLAN_OUT_OF_RANGE=VLAN ID must be a number between 0 and 4094 Please add a period. Line 385: ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage Domain.\n\ Line 386: -Please attach Data Domain to the Data Center first. Line 387: ERROR_CANNOT_REMOVE_POOL_WITH_ACTIVE_DOMAINS=Cannot remove Data Center which contains active/locked Storage Domains.\n\ Line 388: -Please deactivate all domains and wait for tasks to finish before removing the Data Center. .................................................... File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 378: -If you have problems with the master Data Domain, consider following the recovery process described in the documentation, or contact your system administrator. Line 379: Line 380: ERROR_CANNOT_DESTROY_LAST_STORAGE_DOMAIN_HOST_NOT_ACTIVE=In order to complete the operation a new master Storage Domain needs to be elected, which requires at least one active Host in the Data Center.\n\ Line 381: -Please make sure one of the Hosts is active in the Data Center first. Line 382: NETWORK_VLAN_OUT_OF_RANGE=VLAN ID must be a number between 0 and 4094 Same comment. Line 383: ERROR_CANNOT_ADD_STORAGE_POOL_WITHOUT_DATA_DOMAIN=Cannot attach Storage Domain.\n\ Line 384: -Please attach Data Domain to the Data Center first. Line 385: ERROR_CANNOT_REMOVE_POOL_WITH_ACTIVE_DOMAINS=Cannot remove Data Center which contains active/locked Storage Domains.\n\ Line 386: -Please deactivate all domains and wait for tasks to finish before removing the Data Center. -- To view, visit http://gerrit.ovirt.org/10692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d22b7d4a8b8482c9d844d8a29a13590c3e2a9cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
