Alissa Bonas has posted comments on this change.

Change subject: core: TarTest - assume Unix OS
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java
Line 78: 
Line 79:     @Test
Line 80:     public void testSimple() throws Exception {
Line 81:         assumeTrue(SystemUtils.IS_OS_UNIX);
Line 82: 
What happens to the code itself (not the test, but the Tar code that is tested 
here) when it's ran on non linux/unix environment?
Shouldn't it also be taken care of?
Line 83:         File tmpTar = null;
Line 84:         File tmpDir1 = null;
Line 85:         File tmpDir2 = null;
Line 86: 


--
To view, visit http://gerrit.ovirt.org/10739
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c80cb652f4d3e633295d9bd88bc05d806c1d34f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to