Muli Salem has uploaded a new change for review.
Change subject: engine: MacPoolManager - Read lock for Available Addresses
......................................................................
engine: MacPoolManager - Read lock for Available Addresses
This patch adds a read lock for the getAvailableMacs() method.
Change-Id: I2492d0d196c0f88e06677bb5d7a55fed23f20bbb
Signed-off-by: Muli Salem <msa...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/10745/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
index 71912af..85fc81d 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
@@ -170,7 +170,20 @@
}
public int getavailableMacsCount() {
- return availableMacs.size();
+ log.infoFormat("MacPoolManager::getAvailableMacsCount - entered");
+ lockObj.readLock().lock();
+ try {
+ if (!initialized) {
+ logInitializationError("Failed to get available Macs count.");
+ throw new
VdcBLLException(VdcBllErrors.MAC_POOL_NOT_INITIALIZED);
+ }
+
+ int availableMacsSize = availableMacs.size();
+ log.infoFormat("MacPoolManager:: AvailableMacsCount = {0}",
availableMacsSize);
+ return availableMacsSize;
+ } finally {
+ lockObj.readLock().unlock();
+ }
}
public void freeMac(VmNetworkInterface iface) {
--
To view, visit http://gerrit.ovirt.org/10745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2492d0d196c0f88e06677bb5d7a55fed23f20bbb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
