Liron Aravot has posted comments on this change.
Change subject: userportal: VM/Pool handling refactored
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java
Line 399: boolean found = false;
Line 400: for (VM vm : getvms())
Line 401: {
Line 402: if (vm.getVmPoolId() != null &&
vm.getVmPoolId().equals(pool.getvm_pool_id()))
Line 403: {
perhaps it'll be better to use a hashset here to have better runtime rather
than o(n*m)
Line 404: found = true;
Line 405: break;
Line 406: }
Line 407: }
--
To view, visit http://gerrit.ovirt.org/10740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaefb2cffa5fa13bc04cf702abfcc96e485dfad4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
