Shireesh Anjal has posted comments on this change.
Change subject: gluster: Fixed deadlock in nested command execution
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 35: }
Line 36:
Line 37: @Override
Line 38: protected Map<String, String> getExclusiveLocks() {
Line 39: if (!getParameters().isNested()) {
The command which is nested is not "nested" in all scenarios. It could either
be called directly, or called from another command. So we can't configure it
with an annotation. e.g. In this case, the command is used directly when user
sets an option from the UI. It is also called "internally" when creating a new
gluster volume.
Line 40: return
Collections.singletonMap(getVdsGroupId().toString(),
LockingGroup.GLUSTER.name());
Line 41: }
Line 42: return super.getExclusiveLocks();
Line 43: }
--
To view, visit http://gerrit.ovirt.org/10448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id080ad6ac3587ab9c3443cb83969783955dfb082
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
