Omer Frenkel has posted comments on this change.
Change subject: core: ImportVm - use device info only if supported
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 144: * in case the vm object was built from ovf.
Line 145: * not persisted to db.
Line 146: */
Line 147: private String ovfVersion;
Line 148:
i dont see the confusion of ovfVersion (which is exactly the version of the
ovf..)
and dbGeneration, but you are welcome to suggest something better
Line 149: // not persisted to db
Line 150: private Date exportDate;
Line 151:
Line 152: public VmBase() {
--
To view, visit http://gerrit.ovirt.org/10625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f57aad01383b8a3238030b1bae5b6f8a5e1481a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
