Mike Kolesnik has posted comments on this change.
Change subject: engine: CanDoAction of Update/AddNetworkCommand
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
Line 91: }
Line 92: return null;
Line 93: }
Line 94:
Line 95: private ValidationResult networkExists(Network oldNetwork) {
Why not just call getOldNetwork()?
Line 96: return oldNetwork == null
Line 97: ? new ValidationResult(VdcBllMessages.NETWORK_NOT_EXISTS)
Line 98: : ValidationResult.VALID;
Line 99: }
Line 129: }
Line 130: }
Line 131: return ValidationResult.VALID;
Line 132: }
Line 133:
Why not just call getOldNetwork()?
Line 134: private ValidationResult notChangingManagementNetworkName(Network
oldNetwork) {
Line 135: String managementNetwork = Config.<String>
GetValue(ConfigValues.ManagementNetwork);
Line 136: return oldNetwork.getName().equals(managementNetwork) &&
Line 137: !getNetworkName().equals(managementNetwork)
--
To view, visit http://gerrit.ovirt.org/10626
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcf0f43957eddfd55261832729931579abbc3e8d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
