Daniel Erez has posted comments on this change. Change subject: webadmin: Added the ability to define a 'no items' message. ......................................................................
Patch Set 12: * There's a problem with 'Network Interfaces' sub-tab under 'Hosts' main-tab: 'no items' message is always displayed (even when items are available..). It's probably since the sub-tab is composed of a table-header and a form (HostInterfaceForm). Simply hiding the table content should solve it (the actual items are displayed within the form). * Regarding @author annotation in the code: ** We do get credit for the code, per line... (you can view it using 'git blame'). ** Another alternative: vdsm project maintains 'AUTHORS' file for listing contributors. We can suggest a similar one for ovirt-engine project. -- To view, visit http://gerrit.ovirt.org/9830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If808e7c1bc92877d3f59b766985900a2c8ffd216 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
