Arik Hadas has uploaded a new change for review.
Change subject: core: ResourceManager#InternalSetVmStatus cleanup
......................................................................
core: ResourceManager#InternalSetVmStatus cleanup
Remove unnecessary local field 'vmStatus'.
Change-Id: Ie65daceebb3d34d36e8baf8e1c38e3a669f73e7d
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/10617/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
index 176f0ab..6a3cb75 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
@@ -6,6 +6,7 @@
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
+import org.apache.commons.lang.StringUtils;
import org.ovirt.engine.core.common.AuditLogType;
import org.ovirt.engine.core.common.businessentities.IVdsEventListener;
import org.ovirt.engine.core.common.businessentities.VDS;
@@ -238,12 +239,11 @@
* @param vm
* @param status
*/
- public void InternalSetVmStatus(VM vm, VMStatus status) {
+ public void InternalSetVmStatus(VM vm, final VMStatus status) {
vm.setStatus(status);
- VMStatus vmStatus = vm.getStatus();
- boolean isVmStatusDown = VM.isStatusDown(vmStatus);
+ boolean isVmStatusDown = VM.isStatusDown(status);
- if (isVmStatusDown || vmStatus == VMStatus.Unknown) {
+ if (isVmStatusDown || status == VMStatus.Unknown) {
resetVmAttributes(vm);
if (isVmStatusDown) {
--
To view, visit http://gerrit.ovirt.org/10617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie65daceebb3d34d36e8baf8e1c38e3a669f73e7d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
