Liron Aravot has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
Line 107: String[] splitRule = rule.split("#");
Line 108: int currVcpu = Integer.parseInt(splitRule[0]);
Line 109: if (currVcpu >= maxvCPU) {
Line 110: // ERROR maps to a non existent vcpu
Line 111:
addCanDoActionMessage(VdcBllMessages.VM_PINNING_VCPU_DOES_NOT_EXIST);
I'd just change those to returnFailCanDoAction(...) when you rebase, but that's
up to you.
Line 112: return false;
Line 113: }
Line 114: if (!vcpus.add(currVcpu)) {
Line 115: // ERROR contains more then one definition for the
same vcpu
--
To view, visit http://gerrit.ovirt.org/10364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I690b60fcde6bf337058246ef9b1ee24fa3b7220a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslom...@redhat.com>
Gerrit-Reviewer: Andrew Cathrow <and...@cathrow.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslom...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
