Gilad Chaplik has posted comments on this change.

Change subject: userportal: Added caching to user portal page webadmin: Added 
caching to webadmin page
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
frontend/webadmin/modules/frontend-overlay/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/CachingFilter.java
Line 53:     public void doFilter(ServletRequest request, ServletResponse 
response,
Line 54:             FilterChain chain) throws IOException, ServletException {
Line 55:         // Cast to HttpServletRequest/Response.
Line 56:         final HttpServletRequest httpRequest = (HttpServletRequest) 
request;
Line 57:         final HttpServletResponse httpResponse = (HttpServletResponse) 
response;
LOL
Line 58: 
Line 59:         if (cacheFilterPatternMathes(httpRequest)) {
Line 60:             HttpServletResponseWrapper responseWrapper = 
getCacheHeaderResponseWrapper(httpResponse);
Line 61:             httpResponse.setHeader(CACHE_CONTROL, CACHE_YEAR);


Line 104:                     httpResponse.setHeader(name, value);
Line 105:                 }
Line 106:             }
Line 107:         };
Line 108:     }
got it.
Line 109: 
Line 110:     private boolean cacheFilterPatternMathes(HttpServletRequest 
httpRequest) {
Line 111:         boolean result = false;
Line 112:         if (null != cachePattern) {


--
To view, visit http://gerrit.ovirt.org/10449
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d8e02ae542a4aa37bd421bde5582c0f3e9820ad
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to