Moti Asayag has posted comments on this change. Change subject: tools: improve notifier logging ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/log4j.xml Line 31: </root> Line 32: <logger name="com.sun.mail"> Line 33: <level value="ERROR"/> Line 34: </logger> Line 35: Note that there is dependency on utils as well. The dependency on tools is only for org.ovirt.engine.core.tools.common.db.StandaloneDataSource. I don't think this by itself should be decoupled from the notifier category. Same goes for utils. If there is any misconfiguration - I'd like to see/control its visibility in the same scope as the service itself. Once said that - I'm in favour of a single category for this service, unless proven otherwise. Line 36: <logger name="org.ovirt.engine.core.tools"> Line 37: <level value="INFO"/> Line 38: </logger> Line 39: -- To view, visit http://gerrit.ovirt.org/10501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaadd9eb23016b4866e5cfa99f919378f19ece1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
