Yair Zaslavsky has posted comments on this change.

Change subject: core: add executor for execution of runnables with 
CountDownLatch
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/thread/LatchedRunnableExecutor.java
Line 12:     /**
Line 13:      * @param runnables
Line 14:      *            - list of runnables for execution
Line 15:      */
Line 16:     public LatchedRunnableExecutor(List<Runnable> runnables) {
Consider having here Collection<Runnable>
Line 17:         this.runnables = runnables;
Line 18:     }
Line 19: 
Line 20:     protected void executeRunnable(LatchedRunnableWrapper runnable) {


--
To view, visit http://gerrit.ovirt.org/10354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia56ff4afac01803ac0753dbf88fcfbfd34e2e56d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to