Vered Volansky has posted comments on this change. Change subject: core:(WIP) VM pool snapshot should not be stateless. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (3 inline comments) .................................................... Commit Message Line 6: Line 7: core:(WIP) VM pool snapshot should not be stateless. Line 8: Line 9: After upgrade RHEVM from 3.0 to 3.1, the snapshots of VM's which are Line 10: part of a pool are marked as stateless although they don't. /don't/aren't Line 11: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already Line 8: Line 9: After upgrade RHEVM from 3.0 to 3.1, the snapshots of VM's which are Line 10: part of a pool are marked as stateless although they don't. Line 11: Line 12: There is not need to save the image_vm_pool_map data in the /not/no Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already Line 15: Line 16: Change-Id: I9aaccd3c624c2ab6bcc6f4a0510b26d37f2c1eee Line 10: part of a pool are marked as stateless although they don't. Line 11: Line 12: There is not need to save the image_vm_pool_map data in the Line 13: stateless_vm_image_map since snapshots which are created for stateless Line 14: VM should already be saved in this table already /already// - either one Line 15: Line 16: Change-Id: I9aaccd3c624c2ab6bcc6f4a0510b26d37f2c1eee Line 17: Bug-Url: https://bugzilla.redhat.com/882621 -- To view, visit http://gerrit.ovirt.org/9794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aaccd3c624c2ab6bcc6f4a0510b26d37f2c1eee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
